mbeckerle commented on a change in pull request #343: Daffodil 2302 fixes
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r400972771
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/compiler/RootSpec.scala
##########
@@ -33,4 +33,9 @@ case class RootSpec(ns: Option[NS], name: String) {
val nsStr = ns.getOrElse("")
"{" + nsStr + "}" + name
}
+}
+
+object RootSpec {
+ def makeRootSpec(optName: Option[String], optNamespace:Option[String]) =
+ optName.map{ RootSpec(optNamespace.map{ NS(_)}, _) }
Review comment:
This is an API, so I can just add an Assert.usage(test) that checks this
additional usage mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
