mbeckerle commented on a change in pull request #343: Daffodil 2302 fixes
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r400990040
##########
File path:
daffodil-cli/src/it/scala/org/apache/daffodil/saving/TestCLISaveParser.scala
##########
@@ -262,6 +262,10 @@ class TestCLISaveParser {
}
}
+ /**
+ * Note that in Daffodil 2.6.0 behavior of external variables changed. They
are not saved as part of binary
+ * compiling. They are a runtime-thing only.
+ */
Review comment:
There are things we can check at compile time. First is that the settings
are going to be legal, which requires that the variables being set are in fact
declared 'external', and that the value provided can be converted to the proper
type.
A warning, that the external vars are checked, but not saved, as part of
save-parser makes sense at the CLI and at the save API call. Internally,
however, where we save/restore (e.g., for every TDML test) we don't want this
warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
