Shanedell commented on a change in pull request #96: URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r836641496
########## File path: build/bin.NOTICE ########## @@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar) Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar) Apache Commons Lang - Copyright 2001-2021 The Apache Software Foundation - + Copyright 2001-2022 The Apache Software Foundation + This product includes software developed at The Apache Software Foundation (https://www.apache.org/). Review comment: So I am confused. That PR is for updating the `bin.NOTICE` and `bin.LICENSE` files for Daffodil. These wouldn't be inside of the `bin.NOTICE` and `bin.LICENSE` correct? Just the root `NOTICE` and `LICENSE` file contents should be inside of the `bin.` files inside of `daffodil-vscode` correct? As the `bin` files between the two should differ as the daffodil-debugger Scala code doesn't use the same dependencies as the daffodil project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
