stevedlawrence commented on a change in pull request #96: URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r836652281
########## File path: build/bin.NOTICE ########## @@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar) Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar) Apache Commons Lang - Copyright 2001-2021 The Apache Software Foundation - + Copyright 2001-2022 The Apache Software Foundation + This product includes software developed at The Apache Software Foundation (https://www.apache.org/). Review comment: Correct, your NOTICE and LICENSE files are correct and don't need to be updated. Those files cover the source code. The bin.NOTICE and bin.LICENSE files cover everything inside the .vsix file, which is significantly more since the .vsix file actually inclues jars. Inside the .vsix file is the daffodil-debugger-3.3.0-1.0.0.zip file, and inside that zip is all the dependencies, including transitive dependencies, of daffodil-debugger. Because daffodil-debugger depends on daffodil, this zip will contain many (or maybe all?) of the same jars that Daffodil depends on. Because of this, the bin.NOTICE and bin.LICENSE files for vscode should probably look very similar to the bin.NOTICE and bin.LICENSE of Daffodil, with the addition of the Daffodil NOTICE and dependencies that are unique to daffodil-debugger (e.g. ip4s, cats, fs2) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
