Shanedell commented on a change in pull request #96: URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r836764685
########## File path: build/bin.NOTICE ########## @@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar) Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar) Apache Commons Lang - Copyright 2001-2021 The Apache Software Foundation - + Copyright 2001-2022 The Apache Software Foundation + This product includes software developed at The Apache Software Foundation (https://www.apache.org/). Review comment: @stevedlawrence Hey Steve, I am going through and updating stuff here so if something doesn't have a NOTICE but has a LICENSE it can be excluded from `bin.NOTICE` if the license is added to `bin.LICENSE` correct? Then if it has a NOTICE but not a LICENSE it goes into `bin.NOTICE` correct? So they only need to be in one or the other? What about something that has neither LICENSE or NOTICE does that just not get added to either file? What if the LICENSE is an Apache license does that need added to that file or we bypass those? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
