stevedlawrence commented on a change in pull request #96: URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r836673540
########## File path: build/bin.NOTICE ########## @@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar) Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar) Apache Commons Lang - Copyright 2001-2021 The Apache Software Foundation - + Copyright 2001-2022 The Apache Software Foundation + This product includes software developed at The Apache Software Foundation (https://www.apache.org/). Review comment: I think the dependency changes look fine. RC3 should be good once this is merged, but I might make sense to include the bin.NOTICE and bin.LICENSE updates in this PR. Also, did you confirm that the updated dependencies did not have a change to their LICENSE or NOTICE files that needs to be incorporated into bin.NOTICE/bin.LICENE? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
