Shanedell commented on a change in pull request #96: URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r836774138
########## File path: build/bin.NOTICE ########## @@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar) Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar) Apache Commons Lang - Copyright 2001-2021 The Apache Software Foundation - + Copyright 2001-2022 The Apache Software Foundation + This product includes software developed at The Apache Software Foundation (https://www.apache.org/). Review comment: So we have these items included but they aren't in either `bin.NOTICE` or `bin.LICENSE` but have Apache Licenses ``` org.typelevel.cats-effect org.typelevel.cats-effect-kernel org.typelevel.cats-effect-std com.monovore.decline-effect com.monovore.decline org.typelevel.log4cats-core org.typelevel.log4cats-slf4j com.google.code.gson.gson org.typelevel.literally ``` This one is in neither and has neither ``` org.typelevel.simulacrum-scalafix-annotations ``` So what do you think is best for these ones just leave them out? Adding the Apache license for all of the above, some are in the same project so it lowers the number down a bit, will cause that files to a bit more lengthy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
