stevedlawrence commented on a change in pull request #96:
URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r837786501



##########
File path: build/bin.NOTICE
##########
@@ -169,3 +166,71 @@ Apache Commons Lang 
(lib/org.apache.commons:commons-lang3-<VERSION>.jar)
   
   This product includes software developed at
   The Apache Software Foundation (https://www.apache.org/).
+
+Apache Commons Codec (lib/commons-codec.commons-codec-<VERSION>.jar)
+  Apache Commons Codec
+  Copyright 2002-2017 The Apache Software Foundation
+
+  src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+  contains test data from http://aspell.net/test/orig/batch0.tab.
+  Copyright (C) 2002 Kevin Atkinson ([email protected])
+
+  
===============================================================================
+
+  The content of package org.apache.commons.codec.language.bm has been 
translated
+  from the original php source code available at 
http://stevemorse.org/phoneticinfo.htm
+  with permission from the original authors.
+  Original source copyright:
+  Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+Apache Commons Logging (lib/commons-logging.commons-logging-<VERSION>.jar)
+  Apache Commons Logging
+  Copyright 2003-2014 The Apache Software Foundation
+
+Apache HttpClient (lib/org.apache.httpcomponents.httpclient-<VERSION>.jar)
+  Apache HttpClient
+  Copyright 1999-2020 The Apache Software Foundation
+
+Apache HttpCore (lib/org.apache.httpcomponents.httpcore-<VERSION>.jar)
+  Apache HttpCore
+  Copyright 2005-2020 The Apache Software Foundation
+
+Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, 
org.apache.logging.log4j.log4j-core-<VERSION>.jar)
+  Apache Log4j
+  Copyright 1999-2019 Apache Software Foundation
+
+  This product includes software developed at
+  The Apache Software Foundation (http://www.apache.org/).
+
+  ResolverUtil.java
+  Copyright 2005-2006 Tim Fennell
+
+  Dumbster SMTP test server

Review comment:
       Yeah, we originally just copied from what other projects do, but it 
should be fine to have a license directory, and is definitely easier to manage. 
However, I'm not sure you can do the same for NOTICES. I think those have to be 
in the NOTICE file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to