stevedlawrence commented on a change in pull request #96:
URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r837651826
##########
File path: build/bin.NOTICE
##########
@@ -1,5 +1,5 @@
Apache Daffodil VS Code Extension
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Review comment:
This has already been fixed in main. Might get a merge conflict for this?
##########
File path: build/bin.LICENSE
##########
@@ -2207,3 +2207,537 @@
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+ This product bundles 'Saxon-HE (Home Edition)', including the following
files:
Review comment:
I think this is already in the bin.LICENSE file? But I think that might
be for an older version of Saxon-HE? It has a lot more subcomponents listed. I
wonder if Saxon-HE removed those components?
##########
File path: build/bin.NOTICE
##########
@@ -169,3 +166,71 @@ Apache Commons Lang
(lib/org.apache.commons:commons-lang3-<VERSION>.jar)
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
+
+Apache Commons Codec (lib/commons-codec.commons-codec-<VERSION>.jar)
+ Apache Commons Codec
+ Copyright 2002-2017 The Apache Software Foundation
+
+ src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+ contains test data from http://aspell.net/test/orig/batch0.tab.
+ Copyright (C) 2002 Kevin Atkinson ([email protected])
+
+
===============================================================================
+
+ The content of package org.apache.commons.codec.language.bm has been
translated
+ from the original php source code available at
http://stevemorse.org/phoneticinfo.htm
+ with permission from the original authors.
+ Original source copyright:
+ Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+Apache Commons Logging (lib/commons-logging.commons-logging-<VERSION>.jar)
+ Apache Commons Logging
+ Copyright 2003-2014 The Apache Software Foundation
+
+Apache HttpClient (lib/org.apache.httpcomponents.httpclient-<VERSION>.jar)
+ Apache HttpClient
+ Copyright 1999-2020 The Apache Software Foundation
+
+Apache HttpCore (lib/org.apache.httpcomponents.httpcore-<VERSION>.jar)
+ Apache HttpCore
+ Copyright 2005-2020 The Apache Software Foundation
Review comment:
We need this Http stuff since it is a dependency of Daffodil, but that's
weird. Not sure why http stuff is a depdency of Daffodil. I wonder if that's an
optional transitive dependency that we can remove in Daffodil 3.4.0?
##########
File path: build/bin.NOTICE
##########
@@ -169,3 +166,71 @@ Apache Commons Lang
(lib/org.apache.commons:commons-lang3-<VERSION>.jar)
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
+
+Apache Commons Codec (lib/commons-codec.commons-codec-<VERSION>.jar)
+ Apache Commons Codec
+ Copyright 2002-2017 The Apache Software Foundation
+
+ src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+ contains test data from http://aspell.net/test/orig/batch0.tab.
+ Copyright (C) 2002 Kevin Atkinson ([email protected])
+
+
===============================================================================
+
+ The content of package org.apache.commons.codec.language.bm has been
translated
+ from the original php source code available at
http://stevemorse.org/phoneticinfo.htm
+ with permission from the original authors.
+ Original source copyright:
+ Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+Apache Commons Logging (lib/commons-logging.commons-logging-<VERSION>.jar)
+ Apache Commons Logging
+ Copyright 2003-2014 The Apache Software Foundation
+
+Apache HttpClient (lib/org.apache.httpcomponents.httpclient-<VERSION>.jar)
+ Apache HttpClient
+ Copyright 1999-2020 The Apache Software Foundation
+
+Apache HttpCore (lib/org.apache.httpcomponents.httpcore-<VERSION>.jar)
+ Apache HttpCore
+ Copyright 2005-2020 The Apache Software Foundation
+
+Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar,
org.apache.logging.log4j.log4j-core-<VERSION>.jar)
+ Apache Log4j
+ Copyright 1999-2019 Apache Software Foundation
+
+ This product includes software developed at
+ The Apache Software Foundation (http://www.apache.org/).
+
+ ResolverUtil.java
+ Copyright 2005-2006 Tim Fennell
+
+ Dumbster SMTP test server
Review comment:
The bin.NOTICE file @tuxji just merged does not list Dumbster or some of
these other things from Log4j. Did Log4j change their notice?
@tuxji, it would help if you could take a scan at this. You're most faimilar
with all the recent changes.
Also, it's a little hard to just diff since the format has changed. Do we
want to standardize all of our license/notice files to the same format?
##########
File path: build/bin.NOTICE
##########
@@ -77,9 +84,6 @@ Apache XML Commons Resolver
(lib/xml-resolver.xml-resolver-<VERSION>.jar)
Apache XML Commons Resolver
Copyright 2006 The Apache Software Foundation.
- This product includes software developed at
- The Apache Software Foundation http://www.apache.org/
-
Review comment:
This line still exists in a few places. This can be removed in all
places except for the very first one at the top.
##########
File path: build/bin.NOTICE
##########
@@ -169,3 +166,71 @@ Apache Commons Lang
(lib/org.apache.commons:commons-lang3-<VERSION>.jar)
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
+
+Apache Commons Codec (lib/commons-codec.commons-codec-<VERSION>.jar)
+ Apache Commons Codec
+ Copyright 2002-2017 The Apache Software Foundation
+
+ src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+ contains test data from http://aspell.net/test/orig/batch0.tab.
+ Copyright (C) 2002 Kevin Atkinson ([email protected])
+
+
===============================================================================
+
+ The content of package org.apache.commons.codec.language.bm has been
translated
+ from the original php source code available at
http://stevemorse.org/phoneticinfo.htm
+ with permission from the original authors.
+ Original source copyright:
+ Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+Apache Commons Logging (lib/commons-logging.commons-logging-<VERSION>.jar)
+ Apache Commons Logging
+ Copyright 2003-2014 The Apache Software Foundation
+
+Apache HttpClient (lib/org.apache.httpcomponents.httpclient-<VERSION>.jar)
+ Apache HttpClient
+ Copyright 1999-2020 The Apache Software Foundation
+
+Apache HttpCore (lib/org.apache.httpcomponents.httpcore-<VERSION>.jar)
+ Apache HttpCore
+ Copyright 2005-2020 The Apache Software Foundation
+
+Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar,
org.apache.logging.log4j.log4j-core-<VERSION>.jar)
Review comment:
This is already above. One of those can be removed.
##########
File path: build/bin.LICENSE
##########
@@ -2207,3 +2207,537 @@
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+ This product bundles 'Saxon-HE (Home Edition)', including the following
files:
+ - lib/net.sf.saxon.Saxon-HE-<VERSION>.jar in in
daffodil-debugger-<VERSION>.zip
+ These files are available under the MPL 2.0 license:
+
+ Most of the open source code in the Saxon product is governed by the
Mozilla Public
Review comment:
The "Most of a the open source..." part is copied straight out of the
Saxon-HE LICENSE.txt file, so we probably want to keep that verbatim.
The line "These files are available under the MPL 2.0 license:" is something
we add, and we are free to change. According to the Saxon license, the only
thing that isn't MPL 2.0 is a one subcomponent, which is MIT. So alternatively
we could say
"These files are available under the MPL 2.0 license and MIT license."
Though, that almost sounds like saxon is dual licensed, which is not the
case. So maybe your more generic message is better, and people who care just
need to read the whole thing to know the license?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
