stevedlawrence commented on a change in pull request #96: URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r836780340
########## File path: build/bin.NOTICE ########## @@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar) Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar) Apache Commons Lang - Copyright 2001-2021 The Apache Software Foundation - + Copyright 2001-2022 The Apache Software Foundation + This product includes software developed at The Apache Software Foundation (https://www.apache.org/). Review comment: For dependencies that are under the Apache License, you must add the dependencies NOTICE content to bin.NOTICE. If it does not have a NOTICE file then you do not need to do anything for that dependency. And because it's ALv2 license, you not need to add anything to the bin.LICENSE file since it's the same as the vscode license. For dependencies that are under a license other than the Apache License, you must add its LICENSE information to the bin.LICENSE file. Nothing should be added to the bin.NOTICE file, unless the license is a [Category B](https://www.apache.org/legal/resolved.html#category-b) license, but we don't see those very often, and in most cases the information should be in a README rather than the bin.NOTICE. If a dependency does not have a LICENSE file, then we need to figure out what its license is and handle it according to the above rules. For example, sometimes the license is just mentioned in a README or file headers. If we cannot determine the license, it is assumed to be [Category X](https://www.apache.org/legal/resolved.html#category-x) and we cannot use the dependency until the author/authors specify a license and we determine its compatibility with ASF licensing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
