stevedlawrence commented on a change in pull request #96: URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r836783825
########## File path: build/bin.NOTICE ########## @@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar) Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar) Apache Commons Lang - Copyright 2001-2021 The Apache Software Foundation - + Copyright 2001-2022 The Apache Software Foundation + This product includes software developed at The Apache Software Foundation (https://www.apache.org/). Review comment: Sorry, I didn't see the other comments until after I posted the above, but I think it answers your questions. > Also in the PR for daffodil some of the items that have no NOTICE in JAR have the license mentioned in bin.LICENSE so could those just be removed from the bin.NOTICE? Some of them also have Apache licenses so should those be removed from the bin.NOTICE file? I suggested to John that we do not include anything in bin.NOTICE for dependencies that do not have a NOTICE file. I'm not sure if a final decision has been made about that, but that is my preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
