jadams-tresys commented on code in PR #1479:
URL: https://github.com/apache/daffodil/pull/1479#discussion_r2070200497
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/core/compiler/Compiler.scala:
##########
@@ -31,17 +31,21 @@ import scala.collection.mutable.ArrayBuffer
import scala.util.Try
import scala.xml.Node
+import org.apache.daffodil.api.compiler.{ ProcessorFactory =>
JProcessorFactory }
+import org.apache.daffodil.api.exceptions.{ InvalidParserException =>
JInvalidParserException }
+import org.apache.daffodil.api.{ CodeGenerator => JCodeGenerator }
+import org.apache.daffodil.api.{ DataProcessor => JDataProcessor }
Review Comment:
2 things:
1. Just to make sure I'm tracking the API changes here correctly, we are
dropping having separate Scala and Java APIs and instead having a single
unified API that is Java compatible?
2. Assuming 1 is correct do we really want to be prefixing everything with
"J"? It made sense when there was separate APIs but unless there is some sort
of loss of functionality when using the new API from Scala. I'm open to ideas
on this but just thought it might not be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
