mbeckerle commented on code in PR #1479:
URL: https://github.com/apache/daffodil/pull/1479#discussion_r2070564403
##########
build.sbt:
##########
@@ -28,20 +28,13 @@ lazy val genTunablesDoc = taskKey[Seq[File]]("Generate
tunables doc from dafext.
lazy val daffodil = project
.in(file("."))
- .enablePlugins(JavaUnidocPlugin, ScalaUnidocPlugin)
+ .enablePlugins(ScalaUnidocPlugin)
.aggregate(
cli,
codeGenC,
- core,
- io,
- japi,
- lib,
Review Comment:
I don't understand why daffodil-io has to be blended in here. I see no Java
API Interface definitions for it, so perhaps that could be factored back out.
re: compilation speed: (timings below use Java25 JVM)
Test1: adding a comment to the Assert.toss method then recmpiling takes
around 1 minute both in the Scala 3 version and current mainline.
Test2: A full recompile is about 1.5 minutes in both cases also.
Test3: Adding a comment to the AdditiveExpression class takes 15 seconds to
recompile on Scala 3 version, and 20 seconds on current mainline.
Test4: Adding a println("test") statement to the
DaffodilParseOutputStreamContentHandler.activePrefixMapping definition takes 7
seconds to recompile on Scala 3, and the current mainline.
That's not comprehensive, but there's no evidence that the Scala 3 combined
runtime1 is much slower to compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
