stevedlawrence commented on code in PR #1479:
URL: https://github.com/apache/daffodil/pull/1479#discussion_r2070472940
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/core/compiler/Compiler.scala:
##########
@@ -31,17 +31,21 @@ import scala.collection.mutable.ArrayBuffer
import scala.util.Try
import scala.xml.Node
+import org.apache.daffodil.api.compiler.{ ProcessorFactory =>
JProcessorFactory }
+import org.apache.daffodil.api.exceptions.{ InvalidParserException =>
JInvalidParserException }
+import org.apache.daffodil.api.{ CodeGenerator => JCodeGenerator }
+import org.apache.daffodil.api.{ DataProcessor => JDataProcessor }
Review Comment:
> we needed to rename them and J seemed like the best option. Any
suggestions?
One alternative could be to just `import org.apache.daffodil.api` and then
classes could do something like
```scala
class DataProcessor extends api.DataProcessor {
...
}
```
Possibly removes some imports and makes also makes clear that thigns are
implementing the API interface.
> Re 1, we are also integrating the new JAVA API into our current backend
for compatibility @stevedlawrence is that right?
Yes, we will now just have a single API that works in both Java and Scala.
Forease of use, it probably doesn't want to reference any Scala-types. This
should make it easy to use for Java people, while still being easy to use for
scala users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
