olabusayoT commented on code in PR #1479:
URL: https://github.com/apache/daffodil/pull/1479#discussion_r2070465720


##########
build.sbt:
##########
@@ -28,20 +28,13 @@ lazy val genTunablesDoc = taskKey[Seq[File]]("Generate 
tunables doc from dafext.
 
 lazy val daffodil = project
   .in(file("."))
-  .enablePlugins(JavaUnidocPlugin, ScalaUnidocPlugin)
+  .enablePlugins(ScalaUnidocPlugin)
   .aggregate(
     cli,
     codeGenC,
-    core,
-    io,
-    japi,
-    lib,

Review Comment:
   We were running into circular dependency issues again where things in one 
module needed the new API  in runtime1, but the new API also needed things in 
that submodule. After a convo with Mike, collapsing them all into the same 
module seemed like the most viable option. I haven't noticed a degradation in 
compilation time (though tbh I wasn't really looking for it)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to