AlexanderSaydakov commented on a change in pull request #209:
URL: https://github.com/apache/datasketches-cpp/pull/209#discussion_r616095109
##########
File path: common/include/serde.hpp
##########
@@ -99,11 +99,11 @@ struct serde<std::string> {
bool failure = false;
try {
for (; i < num && os.good(); i++) {
- uint32_t length = items[i].size();
+ uint32_t length = static_cast<uint32_t>(items[i].size());
Review comment:
this is historical from some Java implementation. we call it out in the
comments above this serde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
