AlexanderSaydakov commented on a change in pull request #209:
URL: https://github.com/apache/datasketches-cpp/pull/209#discussion_r616167224
##########
File path: theta/include/theta_jaccard_similarity_base.hpp
##########
@@ -131,9 +131,9 @@ class jaccard_similarity_base {
template<typename SketchA, typename SketchB>
static typename Union::CompactSketch compute_union(const SketchA& sketch_a,
const SketchB& sketch_b) {
- const unsigned count_a = sketch_a.get_num_retained();
- const unsigned count_b = sketch_b.get_num_retained();
- const unsigned lg_k = std::min(std::max(log2(ceiling_power_of_2(count_a +
count_b)), theta_constants::MIN_LG_K), theta_constants::MAX_LG_K);
+ const auto count_a = sketch_a.get_num_retained();
+ const auto count_b = sketch_b.get_num_retained();
+ const auto lg_k = std::min(std::max(log2(ceiling_power_of_2(count_a +
count_b)), theta_constants::MIN_LG_K), theta_constants::MAX_LG_K);
Review comment:
ok, let's be explicit here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
