AlexanderSaydakov commented on a change in pull request #209:
URL: https://github.com/apache/datasketches-cpp/pull/209#discussion_r616162964
##########
File path: kll/test/kll_sketch_test.cpp
##########
@@ -115,7 +114,7 @@ TEST_CASE("kll sketch", "[kll_sketch]") {
sketch.update(std::numeric_limits<float>::quiet_NaN());
REQUIRE(sketch.is_empty());
- sketch.update(0.0);
+ sketch.update(0);
Review comment:
I vaguely remember that this generated a warning about conversion from
double to float. perhaps this could be 0.0f, but just 0 works fine with no
warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
