AlexanderSaydakov commented on a change in pull request #209:
URL: https://github.com/apache/datasketches-cpp/pull/209#discussion_r616163385
##########
File path: tuple/include/tuple_sketch_impl.hpp
##########
@@ -315,7 +315,7 @@ uint64_t compact_tuple_sketch<S, A>::get_theta64() const {
template<typename S, typename A>
uint32_t compact_tuple_sketch<S, A>::get_num_retained() const {
- return entries_.size();
+ return static_cast<uint32_t>(entries_.size());
Review comment:
I had the same thought, but did not act on it yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
