AlexanderSaydakov commented on a change in pull request #209:
URL: https://github.com/apache/datasketches-cpp/pull/209#discussion_r616160145
##########
File path: kll/include/kll_quantile_calculator_impl.hpp
##########
@@ -102,11 +102,11 @@ uint32_t kll_quantile_calculator<T, C,
A>::chunk_containing_pos(uint64_t pos) co
}
template <typename T, typename C, typename A>
-uint32_t kll_quantile_calculator<T, C,
A>::search_for_chunk_containing_pos(uint64_t pos, uint32_t l, uint32_t r) const
{
+uint32_t kll_quantile_calculator<T, C,
A>::search_for_chunk_containing_pos(uint64_t pos, uint64_t l, uint64_t r) const
{
Review comment:
this is a painful choice for internal helping methods. say, we use some
STL container, and container.size() returns size_t, but we know that we never
put more than 2^32 items there, and somewhere in serialization we reserve
uint32_t field for number of items. at some point we need some casts. maybe
this choice was not ideal, but I don't think there is a perfect way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
