JinyLeeChina commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r757437612
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2225,6 +2236,7 @@ public String getResourceIds(TaskDefinition
taskDefinition) {
return StringUtils.join(resourceIds, ",");
}
+ @Transactional
Review comment:
Will this affect the transaction saved by the workflow? Please verify it.
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2306,6 +2319,7 @@ public int saveProcessDefine(User operator,
ProcessDefinition processDefinition,
/**
* save task relations
*/
+ @Transactional
Review comment:
Please verify
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2284,6 +2296,7 @@ public int saveTaskDefine(User operator, long
projectCode, List<TaskDefinitionLo
/**
* save processDefinition (including create or update processDefinition)
*/
+ @Transactional
Review comment:
Please verify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
