HomminLee commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r764644585
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2225,6 +2236,7 @@ public String getResourceIds(TaskDefinition
taskDefinition) {
return StringUtils.join(resourceIds, ",");
}
+ @Transactional
Review comment:
@JinyLeeChina
1. I only added transaction annotations for methods that contain multiple
operations
2. If inner layer has exception, do you think it is more correct to rollback
outer layer's transaction? If inner layer has no transaction annotation, outer
layer will still receive exception and rollback. If outer layer has no
transaction annotation, inner layer rollback but outer layer insert/update
successful, isn't this the data is inconsistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
