ruanwenjun commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r757503186
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2225,6 +2236,7 @@ public String getResourceIds(TaskDefinition
taskDefinition) {
return StringUtils.join(resourceIds, ",");
}
+ @Transactional
Review comment:
If the outer layer has a try catch of this method, it will have problem.
Anyway, we can avoid this, and remove this Transactional annotation is ok. We
need to avoid this method being called in isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
