ruanwenjun commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r762558817



##########
File path: 
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2225,6 +2236,7 @@ public String getResourceIds(TaskDefinition 
taskDefinition) {
         return StringUtils.join(resourceIds, ",");
     }
 
+    @Transactional

Review comment:
       @caishunfeng @JinyLeeChina Do you have any ideas for this pr, I think 
this pr is acceptable if it can work well and don't introduce a side effect. 
   This prevents someone from calling a method without a transaction(This may 
happen in secondary development).
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to