SbloodyS commented on code in PR #13422:
URL:
https://github.com/apache/dolphinscheduler/pull/13422#discussion_r1073209231
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -820,9 +820,6 @@ public Map<String, Object> updateTaskWithUpstream(User
loginUser, long projectCo
Map<String, Object> result = new HashMap<>();
TaskDefinitionLog taskDefinitionToUpdate =
updateTask(loginUser, projectCode, taskCode,
taskDefinitionJsonObj, result);
- if (result.get(Constants.STATUS) != Status.SUCCESS &&
taskDefinitionToUpdate == null) {
- return result;
- }
Review Comment:
This is used to ensure that meaningless multiple modifications will not be
directly written to the database. We should add the judgement of the
predecessor node instead of remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
