jackfanwan commented on code in PR #13422:
URL:
https://github.com/apache/dolphinscheduler/pull/13422#discussion_r1073423691
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -820,9 +820,6 @@ public Map<String, Object> updateTaskWithUpstream(User
loginUser, long projectCo
Map<String, Object> result = new HashMap<>();
TaskDefinitionLog taskDefinitionToUpdate =
updateTask(loginUser, projectCode, taskCode,
taskDefinitionJsonObj, result);
- if (result.get(Constants.STATUS) != Status.SUCCESS &&
taskDefinitionToUpdate == null) {
- return result;
- }
Review Comment:
> Looks good to me. But I found that some useless code, can you delete
together?
>
>
https://github.com/apache/dolphinscheduler/blob/8be32d4145c851a01d7300cd5a854be9b4a27055/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java#L839-L841
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
