[GitHub] [dolphinscheduler] jackfanwan commented on a diff in pull request #13422: fix when the task details are not modified, the predecessor node cannot be modified

Wed, 18 Jan 2023 00:47:25 -0800 


jackfanwan commented on code in PR #13422:
URL: 
https://github.com/apache/dolphinscheduler/pull/13422#discussion_r1073246455


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -820,9 +820,6 @@ public Map<String, Object> updateTaskWithUpstream(User 
loginUser, long projectCo
         Map<String, Object> result = new HashMap<>();
         TaskDefinitionLog taskDefinitionToUpdate =
                 updateTask(loginUser, projectCode, taskCode, 
taskDefinitionJsonObj, result);
-        if (result.get(Constants.STATUS) != Status.SUCCESS && 
taskDefinitionToUpdate == null) {
-            return result;
-        }

Review Comment:
   > > Why invalid modifications affect the database
   > 
   > Each modification will be insert to the `t_ds_task_definition_log` as a 
newer version.
   > 
   > 
https://github.com/apache/dolphinscheduler/blob/8439b5dc69f2a7dfc1043393bbbb21a8277715da/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java#L754-L775
   
   
![image](https://user-images.githubusercontent.com/61672564/213125123-93eedee1-b299-493c-99f2-3da972cc147d.png)
   if only modify predecessor node, here can return



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to