SbloodyS commented on code in PR #13422:
URL:
https://github.com/apache/dolphinscheduler/pull/13422#discussion_r1073242994
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -820,9 +820,6 @@ public Map<String, Object> updateTaskWithUpstream(User
loginUser, long projectCo
Map<String, Object> result = new HashMap<>();
TaskDefinitionLog taskDefinitionToUpdate =
updateTask(loginUser, projectCode, taskCode,
taskDefinitionJsonObj, result);
- if (result.get(Constants.STATUS) != Status.SUCCESS &&
taskDefinitionToUpdate == null) {
- return result;
- }
Review Comment:
> Why invalid modifications affect the database
Each modification will be insert to the `t_ds_task_definition_log` as a
newer version.
https://github.com/apache/dolphinscheduler/blob/8439b5dc69f2a7dfc1043393bbbb21a8277715da/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java#L754-L775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
