SbloodyS commented on code in PR #13422:
URL:
https://github.com/apache/dolphinscheduler/pull/13422#discussion_r1073232531
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -820,9 +820,6 @@ public Map<String, Object> updateTaskWithUpstream(User
loginUser, long projectCo
Map<String, Object> result = new HashMap<>();
TaskDefinitionLog taskDefinitionToUpdate =
updateTask(loginUser, projectCode, taskCode,
taskDefinitionJsonObj, result);
- if (result.get(Constants.STATUS) != Status.SUCCESS &&
taskDefinitionToUpdate == null) {
- return result;
- }
Review Comment:
I took a quick look at this part of the code and found that you are right.
But if we remove this, each modification will be saved to the database
regardless of whether there is a real change. It makes the judgment of equals
meaningless.
I'm +0 to this way. What do you guys think? @ruanwenjun @caishunfeng
@EricGao888 @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
