leventov commented on a change in pull request #6662: Double-checked locking
bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r238427182
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/JavaScriptAggregatorFactory.java
##########
@@ -58,8 +59,13 @@
private final String fnCombine;
private final JavaScriptConfig config;
- // This variable is lazily initialized to avoid unnecessary JavaScript
compilation during JSON serde
- private JavaScriptAggregator.ScriptAggregator compiledScript;
+ /**
+ * The field is declared volatile in order to ensure safe publication of the
object
+ * in {@link #compileScript(String, String, String)} without worrying about
final modifiers
+ * on the fields of the created object
+ */
+ @Nullable
Review comment:
It shouldnt have MonotonicNonNull AND Nullable. Just MonotonicNonNull
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
