leventov commented on a change in pull request #6662: Double-checked locking
bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r238479518
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/post/JavaScriptPostAggregator.java
##########
@@ -136,19 +143,20 @@ public Object compute(Map<String, Object>
combinedAggregators)
* {@link #compute} can be called by multiple threads, so this function
should be thread-safe to avoid extra
* script compilation.
*/
+ @EnsuresNonNull("fn")
private void checkAndCompileScript()
Review comment:
Please convert to lazy getter and use it as in the previous class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
