leventov commented on a change in pull request #6662: Double-checked locking
bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r238478919
##########
File path:
aws-common/src/main/java/org/apache/druid/common/aws/LazyFileSessionCredentialsProvider.java
##########
@@ -21,27 +21,41 @@
import com.amazonaws.auth.AWSCredentials;
import com.amazonaws.auth.AWSCredentialsProvider;
+import org.checkerframework.checker.nullness.qual.EnsuresNonNull;
+
+import javax.annotation.Nullable;
public class LazyFileSessionCredentialsProvider implements
AWSCredentialsProvider
{
- private AWSCredentialsConfig config;
- private FileSessionCredentialsProvider provider;
+ private final AWSCredentialsConfig config;
+
+ /**
+ * The field is declared volatile in order to ensure safe publication of the
object
+ * in {@link #getUnderlyingProvider()} without worrying about final modifiers
+ * on the fields of the created object
Review comment:
I realised that unlikely that many readers of this code will understand this
passage without the reference to the thread. Please add `, see
https://github.com/apache/incubator-druid/pull/6662#discussion_r237013157` in
the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
