leventov commented on a change in pull request #6662: Double-checked locking
bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r238479210
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/JavaScriptAggregatorFactory.java
##########
@@ -89,7 +95,7 @@ public JavaScriptAggregatorFactory(
@Override
public Aggregator factorize(final ColumnSelectorFactory columnFactory)
{
- checkAndCompileScript();
+ getCompiledScript();
Review comment:
This method should be used instead of `compiledScript` a few lines below,
that was the whole point. Same in other places where getCompiledScript() is
called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
