leventov commented on a change in pull request #6662: Double-checked locking
bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r238653340
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/post/JavaScriptPostAggregator.java
##########
@@ -136,19 +143,20 @@ public Object compute(Map<String, Object>
combinedAggregators)
* {@link #compute} can be called by multiple threads, so this function
should be thread-safe to avoid extra
* script compilation.
*/
+ @EnsuresNonNull("fn")
private void checkAndCompileScript()
{
- if (fn == null) {
- // JavaScript configuration should be checked when it's actually used
because someone might still want Druid
- // nodes to be able to deserialize JavaScript-based objects even though
JavaScript is disabled.
- Preconditions.checkState(config.isEnabled(), "JavaScript is disabled");
-
- // Synchronizing here can degrade the performance significantly because
this method is called per input row.
- // However, early compilation of JavaScript functions can occur some
memory issues due to unnecessary compilation
- // involving Java class generation each time, and thus this will be
better.
+ // JavaScript configuration should be checked when it's actually used
because someone might still want Druid
+ // nodes to be able to deserialize JavaScript-based objects even though
JavaScript is disabled.
+ Preconditions.checkState(config.isEnabled(), "JavaScript is disabled");
+
+ Function syncedFn = fn;
+ if (syncedFn == null) {
Review comment:
I don't understand you message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
