clintropolis commented on a change in pull request #6804: Fix num_replicas
count in sys.segments table
URL: https://github.com/apache/incubator-druid/pull/6804#discussion_r246236959
##########
File path: server/src/main/java/org/apache/druid/client/TimelineServerView.java
##########
@@ -81,5 +81,14 @@
* @return continue or unregister
*/
CallbackAction segmentRemoved(DataSegment segment);
+
+ /**
+ * Called when a segment is removed from a server.
+ *
+ * @param server The server that removed a segment
+ * @param segment The segment that was removed
+ * @return continue or unregister
+ */
+ CallbackAction segmentRemoved(DruidServerMetadata server, DataSegment
segment);
Review comment:
Consider calling this `serverSegmentRemoved` or something similar to reduce
confusion with `segmentRemoved`. I think also maybe the javadocs should clarify
that this event has no bearing on whether or not the timeline still has the
segment in the event, that the other `segmentRemoved` is still the authority in
that regard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
