clintropolis commented on a change in pull request #6804: Fix num_replicas 
count in sys.segments table
URL: https://github.com/apache/incubator-druid/pull/6804#discussion_r246237041
 
 

 ##########
 File path: 
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
 ##########
 @@ -338,12 +348,16 @@ private void addSegment(final DruidServerMetadata 
server, final DataSegment segm
       if (knownSegments == null || !knownSegments.containsKey(segment)) {
         // segmentReplicatable is used to determine if segments are served by 
realtime servers or not
         final long isRealtime = server.segmentReplicatable() ? 0 : 1;
+        final Map<String, Set<String>> serverSegmentMap = new HashMap<>();
+        serverSegmentMap.put(segment.getIdentifier(), 
Sets.newHashSet(server.getName()));
+        final long isPublished = 0;
+        final long isAvailable = 1;
 
 Review comment:
   Maybe these can just be static constants somewhere?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to