clintropolis commented on a change in pull request #6804: Fix num_replicas
count in sys.segments table
URL: https://github.com/apache/incubator-druid/pull/6804#discussion_r246972651
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataHolder.java
##########
@@ -72,9 +74,14 @@ public String getSegmentId()
return segmentId;
}
- public long getNumReplicas()
+ public ImmutableMap<String, ImmutableSet<String>> getsegmentServerMap()
Review comment:
nit: incorrect camel casing. Additionally, I think the naming of this should
be symmetrical with `withReplicas`, so either rename this `getReplicas`, or
rename the other `withSegmentServerMap` maybe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
