clintropolis commented on a change in pull request #6804: Fix num_replicas
count in sys.segments table
URL: https://github.com/apache/incubator-druid/pull/6804#discussion_r246972307
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -168,6 +173,16 @@ public DruidSchema(
removeSegment(segment);
return ServerView.CallbackAction.CONTINUE;
}
+
+ @Override
+ public ServerView.CallbackAction serverSegmentRemoved(
+ final DruidServerMetadata server,
+ final DataSegment segment
+ )
+ {
+ removeSegment(server, segment);
Review comment:
nit leftover overloaded `removeSegment` method here seems confusing, maybe
rename similar to event being renamed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
