clintropolis commented on a change in pull request #6804: Fix num_replicas
count in sys.segments table
URL: https://github.com/apache/incubator-druid/pull/6804#discussion_r246970800
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataHolder.java
##########
@@ -105,14 +112,14 @@ public Builder(
long isPublished,
long isAvailable,
long isRealtime,
- long numReplicas
+ Map<String, Set<String>> segmentServerMap
)
{
this.segmentId = segmentId;
this.isPublished = isPublished;
this.isAvailable = isAvailable;
this.isRealtime = isRealtime;
- this.numReplicas = numReplicas;
+ this.segmentServerMap = segmentServerMap;
Review comment:
I think it would have been ok if variables and functions were left typed
just plain `Map<String, Set<String>>`, and just assigned them an immutable
copy, similar to what `RowSignature` is doing, though I suppose there is
nothing wrong either way. 🙃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
