clintropolis commented on a change in pull request #6864: add 'init' lifecycle
stage for finer control over startup and shutdown
URL: https://github.com/apache/incubator-druid/pull/6864#discussion_r248129638
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskMaster.java
##########
@@ -203,6 +203,9 @@ public void stop()
giant.lock();
try {
+ if (isLeader()) {
+ leadershipListener.stopBeingLeader();
Review comment:
Hmm, I'm not sure... should this be wrapped to be allowed to silently fail
just in case? It appears that it should be ok, but I'm not certain yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
