clintropolis commented on a change in pull request #6864: add 'init' lifecycle
stage for finer control over startup and shutdown
URL: https://github.com/apache/incubator-druid/pull/6864#discussion_r248129983
##########
File path: core/src/main/java/org/apache/druid/guice/LifecycleModule.java
##########
@@ -37,6 +37,7 @@
*/
public class LifecycleModule implements Module
{
+ private final LifecycleScope initScope = new
LifecycleScope(Lifecycle.Stage.INIT);
Review comment:
shutdown runs things in reverse so `INIT` stage runs last which mean the
log4j shutdown now currently always runs last instead of near the end, which
means it's ok for anything to log up until at least the `INIT` phase shutdown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
