clintropolis commented on a change in pull request #6864: add 'init' lifecycle
stage for finer control over startup and shutdown
URL: https://github.com/apache/incubator-druid/pull/6864#discussion_r248210063
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskMaster.java
##########
@@ -203,6 +203,9 @@ public void stop()
giant.lock();
try {
+ if (isLeader()) {
+ leadershipListener.stopBeingLeader();
Review comment:
Hmm, upon further looking at this I _think_ if lifecycle stop handlers on
the leader lifecycle exploded while stopping it would indeed break out and
prevent the listener unregister and probably wreck the outer lifecycle module's
lifecycle stop too. I'll wrap this bit in a try/catch to fail silently since we
are stopping anyway, and would cover this situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
