clintropolis commented on a change in pull request #6864: add 'init' lifecycle stage for finer control over startup and shutdown URL: https://github.com/apache/incubator-druid/pull/6864#discussion_r248128836
########## File path: server/src/main/java/org/apache/druid/initialization/Log4jShutterDownerModule.java ########## @@ -84,7 +84,7 @@ public void configure(Binder binder) } - @ManageLifecycle + @ManageLifecycleInit Review comment: Currently as the only thing in the `INIT` level, always runs last on shutdown, so can add reference to that instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
