clintropolis commented on a change in pull request #6864: add 'init' lifecycle
stage for finer control over startup and shutdown
URL: https://github.com/apache/incubator-druid/pull/6864#discussion_r248094764
##########
File path: server/src/main/java/org/apache/druid/guice/http/LifecycleUtils.java
##########
@@ -26,7 +26,7 @@
{
public static Lifecycle asMmxLifecycle(Lifecycle lifecycle)
{
- final Lifecycle metamxLifecycle = new Lifecycle();
+ final Lifecycle metamxLifecycle = new Lifecycle("http-client");
Review comment:
We could probably look into merging this lifecycle into the top level module
lifecycle since i think historically these were different concrete types, but I
think I would rather do that in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
