github-advanced-security[bot] commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2145721026
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -405,47 +408,48 @@
);
/**
- * Retrieves data source's metadata from the metadata store. Returns null if
there is no metadata.
+ * Retrieves supervisor's metadata from the metadata store. Returns null if
there is no metadata.
*/
- @Nullable DataSourceMetadata retrieveDataSourceMetadata(String dataSource);
+ @Nullable DataSourceMetadata retrieveDataSourceMetadata(String supervisorId);
/**
- * Removes entry for 'dataSource' from the dataSource metadata table.
+ * Removes entry for {@code supervisorId} from the dataSource metadata table.
*
- * @param dataSource identifier
+ * @param supervisorId identifier
*
* @return true if the entry was deleted, false otherwise
*/
- boolean deleteDataSourceMetadata(String dataSource);
+ boolean deleteDataSourceMetadata(String supervisorId);
/**
- * Resets dataSourceMetadata entry for 'dataSource' to the one supplied.
+ * Resets dataSourceMetadata entry for 'supervisorId' to the one supplied.
*
- * @param dataSource identifier
+ * @param supervisorId identifier
* @param dataSourceMetadata value to set
*
* @return true if the entry was reset, false otherwise
*/
- boolean resetDataSourceMetadata(String dataSource, DataSourceMetadata
dataSourceMetadata) throws IOException;
+ boolean resetDataSourceMetadata(String supervisorId, DataSourceMetadata
dataSourceMetadata) throws IOException;
/**
- * Insert dataSourceMetadata entry for 'dataSource'.
+ * Insert dataSourceMetadata entry for 'supervisorId' and 'dataSource'.
*
+ * @param supervisorId identifier
* @param dataSource identifier
* @param dataSourceMetadata value to set
*
* @return true if the entry was inserted, false otherwise
*/
- boolean insertDataSourceMetadata(String dataSource, DataSourceMetadata
dataSourceMetadata);
+ boolean insertDataSourceMetadata(String supervisorId, String dataSource,
DataSourceMetadata dataSourceMetadata);
Review Comment:
## Useless parameter
The parameter 'dataSource' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/9236)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
