kfaraz commented on code in PR #18082: URL: https://github.com/apache/druid/pull/18082#discussion_r2146409319
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpec.java: ########## @@ -77,7 +79,33 @@ private static SeekableStreamSupervisorIngestionSpec checkIngestionSchema( private final boolean suspended; protected final SupervisorStateManagerConfig supervisorStateManagerConfig; + /** + * Base constructor for SeekableStreamSupervisors. + * + * @param id The unique identifier for the supervisor. If this parameter is null, + * the constructor will use the non-null `ingestionSchema` to provide + * a default `dataSource` value as the supervisor ID. This ensures that + * every supervisor has a non-null ID, either user-specified or defaulting to + * the target `dataSource`. + * @param ingestionSchema The ingestion schema that defines the configuration + * for the supervisor. + * @param context A map of additional context parameters. + * @param suspended Indicates whether the supervisor is initially + * suspended. + * @param taskStorage The storage for tasks. + * @param taskMaster The task master responsible for task management. + * @param indexerMetadataStorageCoordinator The coordinator for indexer + * metadata storage. + * @param indexTaskClientFactory The factory for creating index task clients. + * @param mapper The ObjectMapper for JSON serialization and deserialization. + * @param emitter The service emitter for metrics and alerts. + * @param monitorSchedulerConfig The configuration for the monitor scheduler. + * @param rowIngestionMetersFactory The factory for creating row ingestion meters. + * @param supervisorStateManagerConfig The configuration for the supervisor + * state manager. Review Comment: I think we can get rid of these lines. Only the `id` param has any useful info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
