jtuglu-netflix commented on PR #18082: URL: https://github.com/apache/druid/pull/18082#issuecomment-2971227538
@kfaraz : - I've gone with option #1 stated above. - I've updated to assert non-null ID for only spec classes (others are non-identifying, so I let base class handle it, same as other nullable parameters that have been added in the past). - I've removed the different logging ID for supervisors – after adding, it made the code more confusing and didn't seem like something we should support moving forward. Instead, the spec id should be the \*only\* identifier that's used in logs. One can find the associated type, etc. through other logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
