abhishekrb19 commented on code in PR #18709:
URL: https://github.com/apache/druid/pull/18709#discussion_r2488718543


##########
server/src/main/java/org/apache/druid/server/metrics/MonitorsConfig.java:
##########
@@ -79,14 +80,44 @@ public String toString()
            '}';
   }
 
-  public static Map<String, String[]> mapOfDatasourceAndTaskID(final String 
datasource, final String taskId)

Review Comment:
   Done. 
   
   >call out the id dimension as deprecated in the docs and release notes and 
remove it in D37
   
   It looks like the 
[docs](https://druid.apache.org/docs/latest/operations/metrics/#jetty) for the 
six monitors that use this method don’t specify their dimensions clearly. I’ve 
added a general info note under the Real-time metrics seciton. Please let me 
know if I missed anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to