abhishekrb19 commented on code in PR #18709: URL: https://github.com/apache/druid/pull/18709#discussion_r2488395049
########## server/src/main/java/org/apache/druid/server/metrics/DataSourceTaskIdHolder.java: ########## @@ -46,11 +48,13 @@ public class DataSourceTaskIdHolder @Inject(optional = true) BroadcastDatasourceLoadingSpec broadcastDatasourceLoadingSpec = BroadcastDatasourceLoadingSpec.ALL; + @Nullable Review Comment: Added javadoc! >In a follow up PR, we should also fix up the way that DatasourceTaskIdHolder is wired and bind that class itself only for peons. There is no meaning in having this instance bound but contain null values for datasource and task ID. Yeah, there's some [commentary](https://github.com/apache/druid/blame/master/server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java#L115) on why it's setup the way it is. I think we'll need to revisit this Guice bindings for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
