abhishekrb19 commented on code in PR #18709:
URL: https://github.com/apache/druid/pull/18709#discussion_r2488411078
##########
server/src/main/java/org/apache/druid/server/metrics/GroupByStatsMonitor.java:
##########
@@ -41,21 +43,28 @@ public class GroupByStatsMonitor extends AbstractMonitor
{
private final GroupByStatsProvider groupByStatsProvider;
private final BlockingPool<ByteBuffer> mergeBufferPool;
+ private final Map<String, String[]> dimensions;
@Inject
public GroupByStatsMonitor(
GroupByStatsProvider groupByStatsProvider,
- @Merging BlockingPool<ByteBuffer> mergeBufferPool
+ @Merging BlockingPool<ByteBuffer> mergeBufferPool,
+ DataSourceTaskIdHolder dataSourceTaskIdHolder
Review Comment:
Since this monitor is injected, I don’t think it can accept a `Map<String,
String[]>` in the constructor unless it’s bound with a specific name or
qualifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
